-
Notifications
You must be signed in to change notification settings - Fork 4.6k
[Block Library - Query Loop]: Connect scoped block variation to inserter variations
#46410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Block Library - Query Loop]: Connect scoped block variation to inserter variations
#46410
Conversation
|
Size Change: +112 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
I tested the PR, and it works correctly! It is interesting the comment that @mcsf made. If I understand, @mcsf describes a similar use case I shared with #46369. It may be a rare use case, and the developer can fix it easily by registering the same variation for both namespaces. |
805d91d to
e3c4d56
Compare
fb0fe82 to
637c771
Compare
mcsf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
2421def to
12f85c1
Compare
What?
Resolves: #46367
Maybe alternative of: #46369
Currently in Query Loop set up flow a user can choose to
start blank, where the scopedblockvariations are suggested. If extenders of Query Loop have added scopedinsertervariations(exList of Products) and choose tostart blankthe defaultblockvariations will be suggested, which might make no sense or just unwanted.For such
insertervariations there is already in place the mechanism to suggestconnectedpatterns. So this PR implements something similar forconnectedscopedblockpatterns to other Query Loop variations(inserter).I have used a convention:
but that was my quick first thought for the implementation and can be adjusted..
In general scoped
blockvariation are meant to be a simple starting point that usuallyTesting Instructions
Register the below two variations(one `inserter` and one `scope`)
start blankNotes
Would we need to support scoped
blockvariations to be connected to more than oneinsertervariation?Screenshots or screencast
Screen.Recording.2022-12-08.at.5.35.47.PM.mov