BlockVariationPicker: Remove Unnecessary ARIA Role#45916
Merged
alexstine merged 1 commit intoWordPress:trunkfrom Nov 19, 2022
Merged
BlockVariationPicker: Remove Unnecessary ARIA Role#45916alexstine merged 1 commit intoWordPress:trunkfrom
alexstine merged 1 commit intoWordPress:trunkfrom
Conversation
|
|
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @marissa-makes! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
alexstine
approved these changes
Nov 19, 2022
Contributor
alexstine
left a comment
alexstine
left a comment
There was a problem hiding this comment.
@marissa-makes Thanks for the PR! LGTM.
alexstine
added
[Type] Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removes an unnecessary
role=presentationattribute from the aspanwithin theBlockVariationPickercomponent.Why?
As described in #45753, the ARIA
role=presentationattribute is not necessary on an element that doesn't have a native role (in this case, aspancontaining the label for the variation).How?
This change removes the extraneous attribute, which is currently not serving any particular purpose. This change also does not hide the label from assistive technology.
Testing Instructions
Reproduction from the original issue:
observe the role="presentation" attribute is present.Ensure the attribute is not presentTested with Safari+VoiceOver and Chrome+VoiceOver.
Screenshots or screencast
Before:
After: