-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Added InspectorControls import to example #45872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes InspectorControls is not defined
|
|
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @flexseth! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
This was inspired by Ryan's screencast on Twitch today. In other parts of the Block Editor handbook it shows what needs to be imported example here. The What, Why, How, Testing Instructions/etc haven't been included in this PR because it seems like a very simple change. I'm not sure if this is required of all PRs. This is my first PR!! Thanks for the tip on the easy contribution @ryanwelcher Also, feedback on whether imports should be included with all examples? Best/Seth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together @flexseth! It's a great start to updating the docs for this section. I've just made a change to use import instead of accessing the component from the wp global.
docs/how-to-guides/block-tutorial/extending-the-query-loop-block.md
Outdated
Show resolved
Hide resolved
|
Congratulations on your first merged pull request, @flexseth! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
Fixes InspectorControls is not defined
What?
Why?
How?
Testing Instructions
Screenshots or screencast