Skip to content

Conversation

@flexseth
Copy link
Contributor

Fixes InspectorControls is not defined

What?

Why?

How?

Testing Instructions

Screenshots or screencast

Fixes InspectorControls is not defined
@codesandbox
Copy link

codesandbox bot commented Nov 18, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 18, 2022
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @flexseth! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@flexseth
Copy link
Contributor Author

This was inspired by Ryan's screencast on Twitch today. In other parts of the Block Editor handbook it shows what needs to be imported example here.

The What, Why, How, Testing Instructions/etc haven't been included in this PR because it seems like a very simple change. I'm not sure if this is required of all PRs. This is my first PR!!

Thanks for the tip on the easy contribution @ryanwelcher

Also, feedback on whether imports should be included with all examples?

Best/Seth

@ryanwelcher ryanwelcher added [Type] Developer Documentation Documentation for developers Developer Experience Ideas about improving block and theme developer experience labels Nov 18, 2022
Copy link
Contributor

@ryanwelcher ryanwelcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together @flexseth! It's a great start to updating the docs for this section. I've just made a change to use import instead of accessing the component from the wp global.

@ryanwelcher ryanwelcher self-requested a review November 18, 2022 16:41
@ryanwelcher ryanwelcher merged commit 9d936e4 into WordPress:trunk Nov 21, 2022
@github-actions
Copy link

Congratulations on your first merged pull request, @flexseth! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 14.7 milestone Nov 21, 2022
@flexseth flexseth deleted the patch-1 branch March 29, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Developer Experience Ideas about improving block and theme developer experience First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants