Skip to content

Fix for navigation anchor links to close modal #45829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Fix for navigation anchor links to close modal #45829

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
625cf1f
Fix for navigation anchor links to close modal
coreyworrell Nov 16, 2022
722c585
Rename function to be more accurate
coreyworrell Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Rename function to be more accurate
  • Loading branch information
@coreyworrell
coreyworrell committed Nov 16, 2022
commit 722c5856eafeafb8224a84a503a1aa1b4d7fd97c
4 changes: 2 additions & 2 deletions packages/block-library/src/navigation/view-modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function navigationToggleModal( modal ) {
htmlElement.classList.toggle( 'has-modal-open' );
}

function isLinkToAnchorOnSamePage( node ) {
function isLinkToAnchorOnCurrentPage( node ) {
return (
node.hash &&
node.protocol === window.location.protocol &&
Expand All @@ -52,7 +52,7 @@ window.addEventListener( 'load', () => {
navigationLinks.forEach( function ( link ) {
// Ignore non-anchor links and anchor links which open on a new tab.
if (
! isLinkToAnchorOnSamePage( link ) ||
! isLinkToAnchorOnCurrentPage( link ) ||
link.attributes?.target === '_blank'
) {
return;
Expand Down