Conversation
|
|
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
ciampo
reviewed
Nov 1, 2022
Contributor
There was a problem hiding this comment.
LGTM 🚀
Thank you for the cleanup 🧹
I'm not sure if we will migrate this instance and actually remove the component, but in any case it would be good to add a deprecation notice for now.
I think we should migrate that instance. I would also love to remove the component, which should be possible since it's experimental?
ciampo
approved these changes
Nov 1, 2022
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Mark
RadioGroup(andRadio) as deprecated, so we can encourage people to use the alternatives.And some related cleanup:
Radio(wasn't really useful anyway)radio/andradio-context/to subfolders ofradio-group/(just to decrease clutter)Why?
ToggleGroupControl is visually similar and is widely used. In contrast, RadioGroup is only used in one place in the Gutenberg app, and even that is heavily modified visually. It doesn't make sense to keep this around.
I'm not sure if we will migrate this instance and actually remove the component, but in any case it would be good to add a deprecation notice for now.
Testing Instructions
npm run storybook:devand see the RadioGroup story. It should've moved to the Deprecated section.npm run dev, go towp-admin/site-editor.php?postType=wp_template_part, and click the "Add New" button. The RadioGroup in the modal should not have changed.✅ Type checks (
npx tsc --build) still pass