Repository navigation
Conversation
|
|
|
Size Change: +301 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
tellthemachines
left a comment
tellthemachines
left a comment
Contributor
There was a problem hiding this comment.
Thanks for addressing this! The code diff looks good, but in testing I'm seeing block validation errors on existing Cover blocks, both with video and static image backgrounds. I'm also seeing a related error in the console on loading the block editor. These errors should be fixable by adding a deprecation 😅
Member
Author
|
Thanks for testing this @tellthemachines! Unfortunately migrations are probably the most frustrating thing in Gutenberg... I can never get them to work properly. I spent 3 hours trying to make things work just now and I can never figure out migrations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes #38457
Why?
The
object-fit-polyfillwas removed in #34536, butdata-object-fitreferences were not cleaned-up