Post Featured Image Block: Border radius and color not applied on overlay#44276
Closed
RahiDroid wants to merge 4 commits intoWordPress:trunkfrom
Closed
Post Featured Image Block: Border radius and color not applied on overlay#44276RahiDroid wants to merge 4 commits intoWordPress:trunkfrom
RahiDroid wants to merge 4 commits intoWordPress:trunkfrom
Conversation
RahiDroid
changed the title
mikachan
added
the
[Block] Post Featured Image
mikachan
added
Global Styles
mikachan
approved these changes
Sep 20, 2022
Member
mikachan
left a comment
mikachan
left a comment
There was a problem hiding this comment.
Thanks for this! It's working well for me, and I like the way you've used get_block_core_post_featured_image_border_attributes for the border styles.
Contributor
|
Thanks for working on this @RahiDroid 👍 As noted in my comment on #44262, we've got some overlap between our PRs addressing these overlay issues. #44286 also addresses a problem where the markup relating to the overlay is rendered in the editor when it isn't on the frontend. If it is ok with you, I'd like to close this PR in favour of #44286. What do you think? |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
theme.jsonfile.Why?
How?
Testing instructions
Screenshots or screencast