Handle cases when getBlockType returns undefined#41884
Merged
Mamaduka merged 1 commit intoWordPress:trunkfrom Jun 29, 2022
Merged
Handle cases when getBlockType returns undefined#41884Mamaduka merged 1 commit intoWordPress:trunkfrom
Mamaduka merged 1 commit intoWordPress:trunkfrom
Conversation
jorgefilipecosta
approved these changes
Jun 28, 2022
Member
jorgefilipecosta
left a comment
jorgefilipecosta
left a comment
There was a problem hiding this comment.
The changes look good to me 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Added a few checks to determine if result of
getBlockTypeis defined.Why?
As reported in #34462 ,
getBlockTypeselector might returnundefinedand in few places it was assumed that it would return an object.How?
In places that were assuming that result of
getBlockTypeis an object I have added some checks to make sure that case when it'sundefinedis handled too.I get no errors on the console but I see a "null" block after running
wp.data.dispatch('core/blocks').removeBlockTypes('core/missing')and clicking on the block. Not sure if it's correct or not.Testing Instructions
Test instructions can be found here.