Scripts: plugin-zip to include root path files#41439
Merged
Conversation
amustaque97
requested review from
ajitbohra,
gziolo,
nerrad,
ntwb and
ryanwelcher
as code owners
amustaque97
added
[Tool] WP Scripts
|
Size Change: +86 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
gziolo
approved these changes
Jun 1, 2022
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
I tested it again and everything works as before on macOS. We will have to re-test with other environments after publishing to npm later today.
I included a changelog entry for the bug fix and it's ready to land. Thank you so much for handling this PR.
youknowriad
pushed a commit
that referenced
this pull request
Jun 3, 2022
* initial commit * add condition to not add `.` in the path of root files * Update CHANGELOG.md Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
In some special conditions, plugin-zip was not adding root path files as part of zip.
Why?
Fixes: #40528
How?
Add condition to avoid prefix
.in the path of root files.Testing Instructions
$ npx @wordpress/create-block gutenpride$ cd gutenprideScreenshots or screencast