Repository navigation
Refactor preview e2e tests to use Playwright. - #41380
Merged
Merged
Conversation
tellthemachines
added
the
[Type] Automated Testing
|
Size Change: +1.13 kB (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
kevin940726
reviewed
May 31, 2022
kevin940726
left a comment
kevin940726
left a comment
Member
There was a problem hiding this comment.
Thanks for working on this!
I left some suggestions about using Playwright-style assertions. Most of them are repetitive though, just want to make sure we catch everything 😆.
There are also some places where we're not appending the i flag to the names, let's remember to add them wherever they make sense ;)
kevin940726
reviewed
Jun 1, 2022
kevin940726
left a comment
kevin940726
left a comment
Member
There was a problem hiding this comment.
Missing some i flag and some nitpicks. But overall it looks pretty good!
Remember to remove the original puppeteer test though! (We also have to remember to mention it in the migration guide 😅)
| await page.locator( 'role=button[name="Switch to draft"]' ).click(); | ||
|
|
||
| // Change the title. | ||
| await editorPage.type( '[aria-label="Add title"]', ' Draft' ); |
Member
There was a problem hiding this comment.
Oh, I think the name is still Add title and the selector should work. The problem is that we're missing the "pressing OK in the dialog" action in Line 186. See my other comment there :)
Co-authored-by: Kai Hao <kevin830726@gmail.com>
Co-authored-by: Kai Hao <kevin830726@gmail.com>
Co-authored-by: Kai Hao <kevin830726@gmail.com>
Co-authored-by: Kai Hao <kevin830726@gmail.com>
Co-authored-by: Kai Hao <kevin830726@gmail.com>
Co-authored-by: Kai Hao <kevin830726@gmail.com>
Co-authored-by: Kai Hao <kevin830726@gmail.com>
Co-authored-by: Kai Hao <kevin830726@gmail.com>
Contributor
Author
|
Thanks for the reviews! I think I've addressed everything now 😅 |
kevin940726
approved these changes
Jun 3, 2022
kevin940726
left a comment
kevin940726
left a comment
Member
There was a problem hiding this comment.
Looks perfect! Thanks a lot 😍!
kevin940726
reviewed
Jun 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851. Migrate and refactor
preview.test.jsto Playwright. This suite has some known flaky tests so hopefully the migration fixes #37976 and #35387.Why?
See this post for an overview of the migration.
How?
By following the migration guide.
Testing Instructions
npm run test-e2e:playwright -- test/e2e/specs/editor/various/preview.spec.js
Screenshots or screencast