Social Link: add missing 'width' and 'height' attributes#41373
Social Link: add missing 'width' and 'height' attributes#41373Soean merged 1 commit intoWordPress:trunkfrom
Conversation
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @merkys7! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
@merkys7 thank you for working on this 👏🏻 . It would be great if you can add testing instructions. |
|
I tried to test this but as far as I can tell, this icon is never used? When I add the block, I can not find an option to use it. |
yes right, even I was not able to figure it out. That's why I asked the author for steps to reproduce. |
|
It is used as a fallback, if there is no Icon for the service: https://github.com/WordPress/gutenberg/blob/trunk/packages/block-library/src/social-link/index.php#L96 You can test it by editing the code like this: <!-- wp:social-links -->
<ul class="wp-block-social-links"><!-- wp:social-link {"url":"https://wordpress.org/","service":"this-does-not-exist"} /--></ul>
<!-- /wp:social-links --> |
Soean
left a comment
There was a problem hiding this comment.
There is no visible change, but I think it is good to be consistent here.
|
Congratulations on your first merged pull request, @merkys7! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
|
Just noting that this was also reported in Core Trac and linking. |
What?
All SVG in social-link.php have "...<svg width="24" height="24" viewBox="0 0 24 24"..." but the last one named "Share Icon" have no fixed WIDTH and HEIGHT
Why?
No WIDTH and HEIGHT cause the large icon
How?
Adds missing WIDTH and HEIGHT options
Related: https://core.trac.wordpress.org/ticket/51120
Screenshots or screencast