Skip to content

Cover: Add border support using ResizableBox via BlockPopover #41153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 31, 2023
Merged

Cover: Add border support using ResizableBox via BlockPopover #41153

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fe399d7
Move ResizableBox to BlockPopover for Cover block borders
aaronrobertshaw May 18, 2022
c3dac56
Fix resizable box popover
aaronrobertshaw Mar 9, 2023
fae68e6
Fix issue preventing inner block selection
aaronrobertshaw Mar 9, 2023
e16a401
Fix overflow hidden style being omitted
aaronrobertshaw Mar 10, 2023
c0709c8
Use lock/unlock for experimental ResizableBoxPopover
aaronrobertshaw Mar 10, 2023
306c7d4
Pass showHandle to ResizableBox only
aaronrobertshaw Mar 16, 2023
ac5f302
Ensure size gets passed through to ResizableBox
aaronrobertshaw Mar 16, 2023
f95be25
Improve non-pixel suppport
aaronrobertshaw Mar 16, 2023
492e099
Fix quick dragging when resizing the cover block
talldan Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Pass showHandle to ResizableBox only
  • Loading branch information
@aaronrobertshaw
aaronrobertshaw committed Mar 23, 2023
commit 306c7d48747644c8152cc99bbabe1bc59b644c27
2 changes: 2 additions & 0 deletions packages/block-library/src/cover/edit/resizable-cover-popover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export default function ResizableCoverPopover( {
onResize,
onResizeStart,
onResizeStop,
showHandle,
width,
...props
} ) {
Expand Down Expand Up @@ -59,6 +60,7 @@ export default function ResizableCoverPopover( {
onResizeStop( elt.clientHeight );
setIsResizing( false );
},
showHandle,
__experimentalShowTooltip: true,
__experimentalTooltipProps: {
axis: 'y',
Expand Down