Refactor: Reuse code of the editor placeholder across Post Comments and Post Comments Form #40560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -128 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
michalczaplinski
added
[Block] Comments Form
michalczaplinski
changed the title
Contributor
|
Thanks a lot @michalczaplinski! 🚀 |
ndiego
added
the
Backport to WP 6.9 Beta/RC
adamziel
removed
the
Backport to WP 6.9 Beta/RC
Contributor
|
While it's just a code change, it'd be nice if we could backport this for WP 6.0.1 in order to facilitate other fixes planned for the point release (i.e. fewer conflicts when applying patches etc). |
ockham
added
the
Backport to WP Minor Release
adamziel
added a commit
that referenced
this pull request
Jun 21, 2022
…nd Post Comments Form (#40560) * Create a separate template for the Comments Form * Use the form in the Post Comments block * Add the missing "return" in the CommentForm
Contributor
|
I just cherry-picked this PR to the wp/6.0 branch to get it included in the next release: 7e7d6cd |
adamziel
removed
the
Backport to WP Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Create a
CommentsFormcomponent that is re-used in the editor across both Post Comments and the Post Comments Form blocks.This PR has no functional changes, it's a refactoring.
Why?
This is based on suggestion by @ockham in #40484 (review)
Previously, there was a duplication of code between the Post Comments and the Post Comments Form blocks.
Testing Instructions