Webfonts API: Return font family slug when registering a webfont#40120
Merged
Webfonts API: Return font family slug when registering a webfont#40120
Conversation
zaguiini
force-pushed
the
update/return-font-family-slug-when-registering-webfont
branch
from
608efc3 to
4d84d18
Compare
Contributor
TestingRequirements
// I tested this PR by error logging the output of wp_register_webfont and
// wp_register_webfonts in the functions.php file of the currently active theme
$slug = wp_register_webfont(
array(
'font-family' => 'Roboto',
'font-style' => 'normal',
'font-stretch' => 'normal',
"font-weight" => "900",
'src' => array( 'file:./assets/fonts/Roboto-Regular.ttf' ),
)
);
// Outputs 'roboto'
error_log( $slug );$slugs = wp_register_webfonts(array(
array(
'font-family' => 'Roboto',
'font-style' => 'normal',
'font-stretch' => 'normal',
"font-weight" => "900",
'src' => array( 'file:./assets/fonts/Roboto-Regular.ttf' ),
)
));
// Outputs [ 'roboto' ]
error_log( $slugs ); |
jeyip
approved these changes
Apr 7, 2022
zaguiini
deleted the
update/return-font-family-slug-when-registering-webfont
branch
bph
added
the
Needs Dev Note
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Return the font family slug when registering a webfont.
Why?
There are cases where you want to be aware of the font family slug. One example is https://github.com/Automattic/jetpack/pull/23810/files#diff-67965f8a19767c6775dd0d0949ed5830c22bda270ec3c1835f801649e98596c2R70.
Returning the slug removes the need to call
WP_Webfonts::get_font_slugafter registering a webfont.How?
Simply returning the
$slugvariable from theregister_webfontmethod is enough.Testing Instructions
You should check that the font family slug is returned after calling
wp_register_webfontandwp_register_webfonts.