Skip to content

[WIP] Drop Zone: Use block dropzone when dropping image on empty block #40115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[WIP] Drop Zone: Use block dropzone when dropping image on empty block #40115

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a11bfa4
Initial experimentation with drop zones when hovering over an empty b…
apeatling Apr 6, 2022
7047792
Linter
apeatling Apr 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Initial experimentation with drop zones when hovering over an empty b… 
…lock.
  • Loading branch information
@apeatling
apeatling committed Apr 20, 2022
commit a11bfa4628dba84f6aae05fd1912264526ad3d53
15 changes: 12 additions & 3 deletions packages/block-editor/src/components/use-block-drop-zone/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,16 +112,25 @@ export default function useBlockDropZone( {
// Ensure the element is a block. It should have the `wp-block` class.
( element ) => element.classList.contains( 'wp-block' )
);
const targetBlock = () => {
if ( event.srcElement.dataset?.empty === 'true' ) {
return event.target;
}

return false;
};
const targetIndex = getNearestBlockIndex(
blockElements,
{ x: event.clientX, y: event.clientY },
getBlockListSettings( targetRootClientId )?.orientation
);

setTargetBlockIndex( targetIndex === undefined ? 0 : targetIndex );
if ( ! targetBlock() ) {
setTargetBlockIndex( targetIndex === undefined ? 0 : targetIndex );

if ( targetIndex !== null ) {
showInsertionPoint( targetRootClientId, targetIndex );
if ( targetIndex !== null ) {
showInsertionPoint( targetRootClientId, targetIndex );
}
}
}, [] ),
200
Expand Down