👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @mauriac! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

Thanks for your contribution!! It's an amazing work 🎉

Test Report: Unify comments link markup

Env:

• Localhost: wp-env
• Browser: Chrome
• WordPress: latest trunk
• Gutenberg: latest trunk and without the plugin activated
• OS: macOS Monterey

Steps to reproduce:

• Go to Posts > Add New
• Add 3 comments to the post
• Add a Comments Query Loop Block.
• Enable comment pagination so we can have an older and newer comments link. (3 comments, 1 comment per page).
• Tested with both order options, last and first page as default.

Before applying the PR on the default page:

• Comment pagination number link of the first/last page is different than the first/last page written link. ❌
  
  

Able to reproduce the issue ✅

After applying the PR:

• Comment pagination number link of the first/last page is the same as the first/last page written link. ✅
  
  

Findings

• Able to reproduce the issue ✅
• Confirm the PR resolves the issue ✅

Questions

• Is setting the cpage the best solution in this case? It is true that it does not modify any core function which is fine. It would be great to have some feedback.
• Could be interfering with this bug fix? Both unit test and e2e are passing, but I'm guessing if we are adding some overload here.

cc: @hellofromtonya @ironprogrammer , maybe can give us a more experienced view.

Is setting the cpage the best solution in this case? It is true that it does not modify any core function which is fine. It would be great to have some feedback.

If the goal is to make each number have it corresponding cpage in their respective link, then I'd suggest doing that work within the Core functions. Why? To unify the experience across block and classic; for consistency; to decrease efforts to maintain code (spreading out where cpage is touched makes it harder to maintain the code).

Core handles the paginated links. If there's a bug or block-specific need, I'd suggest working within the Core functions to make them work across all needs.

Thanks for reviewing @c4rl0sbr4v0 and @hellofromtonya. I was wondering if the core wasn't the best place to fix the bug, but since it's Gutenberg ticket I assumed that Gutenberg is the best location to fix it... I could have followed my first thought...

Well then, so next, I'll open a ticket into core trac and fix the bug over there... any objection? Or any other thoughts?

Thanks.

Well then, so next, I'll open a ticket into core trac and fix the bug over there... any objection? Or any other thoughts?

Not on my side. Opening a ticket into core with the fix seems to be the best solution. We can close this PR then. Sorry for the inconvenience.