add min/max in LetterSpacingControl component#39994
Closed
amustaque97 wants to merge 1 commit intotrunkfrom
Closed
add min/max in LetterSpacingControl component#39994amustaque97 wants to merge 1 commit intotrunkfrom
LetterSpacingControl component#39994amustaque97 wants to merge 1 commit intotrunkfrom
Conversation
In this commit, I have added `min` and `max` control to `LetterSpacingControl` component. This will help in avoiding letters overlapping in case of -ve value and too much spacing in case of bigger letter spacing.
|
Size Change: +12 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
|
I don't think this is an issue that needs a fix. At least not in its current form of an arbitary min of 0.1 Please see my comment in the related issue #39993 (comment) |
Member
Author
|
Closing this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #39993
What?
In this PR, I have added
minandmaxcontrol toLetterSpacingControlcomponent. This will help in avoiding letters overlapping in case of -ve value
and too much spacing in case of bigger letter spacing.
Why?
How?
Testing Instructions
Screenshots or screencast