Skip to content

Scripts: Add .jsx file extension to Webpack#39613

Merged
gziolo merged 1 commit intoWordPress:trunkfrom
EliezerSPP:patch-1
Mar 28, 2022
Merged

Scripts: Add .jsx file extension to Webpack#39613
gziolo merged 1 commit intoWordPress:trunkfrom
EliezerSPP:patch-1

Conversation

@EliezerSPP
Copy link
Copy Markdown
Contributor

@EliezerSPP EliezerSPP commented Mar 21, 2022

What?

Add .jsx file extension to Webpack Config

Why?

Import .jsx files without the extension

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 21, 2022
@github-actions
Copy link
Copy Markdown

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @EliezerSPP! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@gziolo gziolo added [Tool] WP Scripts /packages/scripts [Type] Enhancement A suggestion for improvement. labels Mar 22, 2022
@gziolo
Copy link
Copy Markdown
Member

gziolo commented Mar 24, 2022

I’m surprised it was missing. Thank you for opening PR 👍

I guess it’s because we don’t use this extension in the Gutenberg project but other projects should be free to follow whatever the prefer.

Would you mind including a short entry in the CHANGELOG file similar to:

https://github.com/WordPress/gutenberg/blob/trunk/packages/scripts/CHANGELOG.md#bug-fix

@gziolo gziolo merged commit 799c61f into WordPress:trunk Mar 28, 2022
@github-actions
Copy link
Copy Markdown

Congratulations on your first merged pull request, @EliezerSPP! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 13.0 milestone Mar 28, 2022
gziolo added a commit that referenced this pull request Mar 28, 2022
@gziolo
Copy link
Copy Markdown
Member

gziolo commented Mar 28, 2022

Would you mind including a short entry in the CHANGELOG file similar to:

https://github.com/WordPress/gutenberg/blob/trunk/packages/scripts/CHANGELOG.md#bug-fix

Added with f3b4f44.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Tool] WP Scripts /packages/scripts [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants