Merged
Conversation
kjellr
added
[Type] Bug
|
Size Change: +51 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Mar 18, 2022
Contributor
jasmussen
left a comment
jasmussen
left a comment
There was a problem hiding this comment.
Nice one! Totally broken in trunk right now:
This PR fixes it:
I pushed a small fix for the awkward upload button positioning in the placeholder in the GIF above, so it looks good now:
This one is definitely safe to land. Thank you Kjell!
carolinan
approved these changes
Mar 18, 2022
jostnes
pushed a commit
to jostnes/gutenberg
that referenced
this pull request
Mar 23, 2022
* Fix site logo center alignment * Keep data-align div rule there too. * Fix for placeholder. Co-authored-by: jasmussen <joen@automattic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The site logo's center alignment rules rely on a
[data-align]div that no longer exists for themes that support layout (#38613). This PR adds in an additional rule to get the alignment working for that use case.Testing:
Sample markup:
Screenshots: