Load unminified JS when SCRIPT_DEBUG is true.#38756
Closed
noahtallen wants to merge 1 commit intotrunkfrom
Closed
Conversation
youknowriad
reviewed
Feb 11, 2022
| if ( defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ) { | ||
| // We can't replace the glob call above with index.js because the PHP | ||
| // asset file is associated with the .min file. (index.min.asset.php). | ||
| $path = str_replace( '.min.js', '.js', $path ); |
Contributor
There was a problem hiding this comment.
When running npm run dev we only generate .min.js files, though in reality it's a non minified file. Should we update the npm run dev build step to also include .js files? maybe we can just avoid breakage in this case and always load the non minified versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #23960. (Though, I wonder if this will not be possible because of #32621.)
When
SCRIPT_DEBUGis true, loadindex.jsbuild files instead ofindex.min.jsbuild files.Testing Instructions
Locally, in
wp-env,SCRIPT_DEBUGis true by default. If you have no other overrides, you should see non-minified files in the debug devtools tab when loading the editor.Then, add this to
.wp-env.jsonor.wp-env.override.json:Then, when loading the editor, you'll see minified files in the debug devtools tab:
Screenshots
Minified files:
Unminified files:
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).