Skip to content

[RNMobile] Prevent bold headings after autocorrection#38633

Merged
twstokes merged 6 commits intotrunkfrom
rnmobile/bug/aztec-bold-headings
Feb 14, 2022
Merged

[RNMobile] Prevent bold headings after autocorrection#38633
twstokes merged 6 commits intotrunkfrom
rnmobile/bug/aztec-bold-headings

Conversation

@twstokes
Copy link
Copy Markdown
Contributor

@twstokes twstokes commented Feb 8, 2022 •
edited
Loading

Description

Related PRs:

Testing Instructions

See Gutenberg Mobile PR for testing instructions:

Screenshots

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@twstokes twstokes changed the title Update WordPress-Aztec-iOS version to 1.19.8. [RNMobile] Retain Heading attribute when headings are autocorrected. Feb 9, 2022
@twstokes twstokes changed the title [RNMobile] Retain Heading attribute when headings are autocorrected. [RNMobile] Prevent bold headings after autocorrecting Feb 9, 2022
@twstokes twstokes force-pushed the rnmobile/bug/aztec-bold-headings branch from 107e1a7 to 421574b Compare February 9, 2022 03:17
@twstokes twstokes self-assigned this Feb 9, 2022
@twstokes twstokes mentioned this pull request Feb 9, 2022
Merged
2 tasks
@twstokes twstokes changed the title [RNMobile] Prevent bold headings after autocorrecting [RNMobile] Prevent bold headings after autocorrection Feb 9, 2022
@twstokes twstokes added [Type] Bug An existing feature does not function as intended Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Feb 9, 2022
@twstokes twstokes force-pushed the rnmobile/bug/aztec-bold-headings branch from bfa4968 to 4dc49c8 Compare February 11, 2022 02:33
@twstokes twstokes mentioned this pull request Feb 11, 2022
Merged
4 tasks
@twstokes twstokes marked this pull request as ready for review February 11, 2022 02:55
@twstokes twstokes requested a review from fluiddot February 11, 2022 02:55
@twstokes twstokes mentioned this pull request Feb 11, 2022
Merged
fluiddot
fluiddot approved these changes Feb 11, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@fluiddot fluiddot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via wordpress-mobile/gutenberg-mobile#4557 (review).

NOTE: An Aztec-iOS release should be done before merging this PR, and it should be updated in the different places where it's referenced (e.g. GB-mobile, Gutenberg and WP-iOS).

@twstokes twstokes force-pushed the rnmobile/bug/aztec-bold-headings branch from 9ab20cd to d053024 Compare February 11, 2022 20:35
fluiddot
fluiddot approved these changes Feb 14, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via wordpress-mobile/gutenberg-mobile#4557 (review).

@twstokes twstokes mentioned this pull request Feb 14, 2022
Closed
@twstokes twstokes merged commit 8d56c4e into trunk Feb 14, 2022
@twstokes twstokes deleted the rnmobile/bug/aztec-bold-headings branch February 14, 2022 23:44
@github-actions github-actions bot added this to the Gutenberg 12.7 milestone Feb 14, 2022
SiobhyB pushed a commit that referenced this pull request Mar 3, 2022
@twstokes @SiobhyB
[RNMobile] Prevent bold headings after autocorrection (#38633)
bb1dd56 
* Point Podfile to Aztec commit.

* Add release notes.

* Remove temporary Aztec commit reference.

* Point RNTAztecView to 1.19.8.

* Update Gutenberg Demo project pods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fluiddot fluiddot fluiddot approved these changes

Assignees

@twstokes twstokes

Labels

Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

Gutenberg 12.7

Development

Successfully merging this pull request may close these issues.

2 participants

@twstokes @fluiddot