Include tests-mysql port in dev:start output#38590
Merged
talldan merged 1 commit intoWordPress:trunkfrom Feb 8, 2022
Merged
Conversation
talldan
approved these changes
Feb 8, 2022
Contributor
talldan
left a comment
There was a problem hiding this comment.
LGTM. Thanks for working on this.
It might be good to tidy up the console output at some point, but while there are only four lines of text it doesn't seem much of an issue. Maybe if anything more is added it can be considered. 😄
Member
|
Thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running
npm run wp-env start, print the host-local port which is mapped for thetests-mysqlcontainer:gutenberg/packages/env/lib/build-docker-compose-config.js
Lines 186 to 195 in 48da1d9
This is in addition to the port for the "standard" mysql container which is printed in a similar manner immediately prior to the line in this change.
My workaround has been to run a script like this:
docker-compose -f $(npm run --silent wp-env install-path)/docker-compose.yml port tests-mysql 3306and inspect the port returned.Testing Instructions
npm inpm run wp-env start3306on thetests-mysqlcontainer.Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist:
*.native.jsfiles for terms that need renaming or removal).