Declare package visibility to query URL handler apps by hypest · Pull Request #38377 · WordPress/gutenberg

hypest · 2022-01-31T14:01:16Z

Description

Fix launching the video preview from the video block on Android 11+.

Testing Instructions

Run the native mobile demo app on Android
Scroll down to find the video block in the demo content
Tap on the video block and then tap on the "Play" button to launch the video preview
Notice that the preview opens in a browser (perhaps asking you to download the video file actually)

Types of changes

Declare that we'll be querying packages for handlers of the android.intent.action.VIEW intent on http and https schemes.

Checklist:

My code is tested.
My code follows the WordPress code style.
My code follows the accessibility standards.
I've tested my changes with keyboard and screen readers.
My code has proper inline documentation.
I've included developer documentation if appropriate.
I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
I've updated related schemas if appropriate.

mchowning

Tested this via the demo app and WPAndroid and tapping on the video is now properly triggering the system intent. Thanks for the fix!

I actually don't remember ever using a <queries> in the manifest file before either, so thanks for also teaching me about that. 😄

hypest · 2022-02-01T10:37:36Z

Thanks for the review Matt! I'll get the gutenberg-mobile side PR green too and then merge this.

hypest · 2022-02-01T11:06:09Z

Green now! Will kick off the merge train.

fluiddot · 2022-02-01T11:26:08Z

packages/react-native-bridge/CHANGELOG.md

+
+## 1.70.1
+


As the PR is already merged I wouldn't apply any correction, but just wanted to share that I think the section shouldn't have been incorporated in this PR as we'll do it when merging the betafix 1.70.1.

Ouch, apologies. The version number mentioned for the iOS 13 item is actually 1.50.0 not 1.70.1 😞 .

Let me know if you think we should fix that in a separate PR or you are planning to do it as part of the 1.70.1 process indeed @fluiddot , thanks!

Let me know if you think we should fix that in a separate PR or you are planning to do it as part of the 1.70.1 process indeed @fluiddot , thanks!

No worries, I'm planning to fix it as part of the release process (reference).

* Declare package visibility to query URL handler apps * Update changelog

fluiddot · 2022-02-01T11:37:05Z

@hypest I'm wondering if after this PR has been merged we should close #38375, wdyt?

hypest · 2022-02-01T13:11:45Z

@hypest I'm wondering if after this PR has been merged we should close #38375, wdyt?

Good point, closed it now. Thanks for the ping @fluiddot !

* Release script: Update react-native-editor version to 1.70.0 * Release script: Update with changes from 'npm run core preios' * Add 1.70.0 section to react-native-editor changelog * Release script: Update react-native-editor version to 1.70.1 * Release script: Update with changes from 'npm run core preios' * [RNMobile] Gallery block: Fix crash when adding images and selecting a gallery item (#38238) * Add the native variant of MediaReplaceFlow Since the MediaReplaceFlow component is not implemented yet in the native version of the editor, we return an empty component instead. * Set MediaPlaceholder props by platform in gallery * Update react-native-editor changelog * Remove autoOpenMediaUpload from web props `autoOpenMediaUpload` prop is only used in the native version of the `MediaPlaceholder` component hence, we don't need to define it in the props set for the web version. * Add gallery block integration tests * Unify shared props between web and native * Add 1.70.1 section to react-native-editor changelog * Declare package visibility to query URL handler apps (#38377) * Declare package visibility to query URL handler apps * Update changelog * Update react-native-bridge changelog Co-authored-by: Stefanos Togoulidis <stefanostogoulidis@gmail.com> Co-authored-by: David Calhoun <438664+dcalhoun@users.noreply.github.com>

ParaskP7 · 2022-02-03T10:56:15Z

ℹ️ This fix made it into the 19.1-rc-3.

* Release script: Update react-native-editor version to 1.70.0 * Release script: Update with changes from 'npm run core preios' * Add 1.70.0 section to react-native-editor changelog * Release script: Update react-native-editor version to 1.70.1 * Release script: Update with changes from 'npm run core preios' * [RNMobile] Gallery block: Fix crash when adding images and selecting a gallery item (#38238) * Add the native variant of MediaReplaceFlow Since the MediaReplaceFlow component is not implemented yet in the native version of the editor, we return an empty component instead. * Set MediaPlaceholder props by platform in gallery * Update react-native-editor changelog * Remove autoOpenMediaUpload from web props `autoOpenMediaUpload` prop is only used in the native version of the `MediaPlaceholder` component hence, we don't need to define it in the props set for the web version. * Add gallery block integration tests * Unify shared props between web and native * Add 1.70.1 section to react-native-editor changelog * Declare package visibility to query URL handler apps (#38377) * Declare package visibility to query URL handler apps * Update changelog * Update react-native-bridge changelog * Release script: Update react-native-editor version to 1.70.2 * Release script: Update with changes from 'npm run core preios' * Mobile - Rich Text - Validate link colors * Mobile - Rich Text - Update naming to match prop * Update Changelog * GutenbergDemo - Restore unwanted archs change * Mobile - Update changelog Co-authored-by: Carlos Garcia <fluiddot@gmail.com> Co-authored-by: Stefanos Togoulidis <stefanostogoulidis@gmail.com>

* Release script: Update react-native-editor version to 1.70.0 * Release script: Update with changes from 'npm run core preios' * Add 1.70.0 section to react-native-editor changelog * Release script: Update react-native-editor version to 1.70.1 * Release script: Update with changes from 'npm run core preios' * [RNMobile] Gallery block: Fix crash when adding images and selecting a gallery item (#38238) * Add the native variant of MediaReplaceFlow Since the MediaReplaceFlow component is not implemented yet in the native version of the editor, we return an empty component instead. * Set MediaPlaceholder props by platform in gallery * Update react-native-editor changelog * Remove autoOpenMediaUpload from web props `autoOpenMediaUpload` prop is only used in the native version of the `MediaPlaceholder` component hence, we don't need to define it in the props set for the web version. * Add gallery block integration tests * Unify shared props between web and native * Add 1.70.1 section to react-native-editor changelog * Declare package visibility to query URL handler apps (#38377) * Declare package visibility to query URL handler apps * Update changelog * Update react-native-bridge changelog * Release script: Update react-native-editor version to 1.70.2 * Release script: Update with changes from 'npm run core preios' * Mobile - Rich Text - Validate link colors * Mobile - Rich Text - Update naming to match prop * Update Changelog * GutenbergDemo - Restore unwanted archs change * Release script: Update react-native-editor version to 1.70.3 * Release script: Update with changes from 'npm run core preios' * [RNMobile] Highlight text: Check if style attribute value is defined during filtering (#38670) * Check if style value is defined before removing extra spaces * Add test case for old text color format * Update react-native-editor changelog Co-authored-by: Carlos Garcia <fluiddot@gmail.com> Co-authored-by: Stefanos Togoulidis <stefanostogoulidis@gmail.com> Co-authored-by: Gerardo <gerardo.pacheco@automattic.com>

hypest added Mobile App - Automation Label used to initiate Mobile App PR Automation Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Jan 31, 2022

hypest changed the base branch from rnmobile/release_1.70.1 to trunk January 31, 2022 14:02

wpmobilebot mentioned this pull request Jan 31, 2022

Declare package visibility to query URL handler apps wordpress-mobile/gutenberg-mobile#4527

Merged

hypest added 2 commits January 31, 2022 16:06

Declare package visibility to query URL handler apps

50d7f3b

Update changelog

42f5534

hypest force-pushed the rnmobile/38375-fix-declare-package-visibility-needs-to-query-url-handlers branch from 8a7ce48 to 42f5534 Compare January 31, 2022 14:06

hypest marked this pull request as ready for review January 31, 2022 18:10

hypest requested a review from mchowning January 31, 2022 18:10

mchowning approved these changes Jan 31, 2022

View reviewed changes

hypest merged commit c25a166 into trunk Feb 1, 2022

hypest deleted the rnmobile/38375-fix-declare-package-visibility-needs-to-query-url-handlers branch February 1, 2022 11:06

github-actions bot added this to the Gutenberg 12.6 milestone Feb 1, 2022

fluiddot reviewed Feb 1, 2022

View reviewed changes

fluiddot pushed a commit that referenced this pull request Feb 1, 2022

Declare package visibility to query URL handler apps (#38377)

d27b727

* Declare package visibility to query URL handler apps * Update changelog

fluiddot mentioned this pull request Feb 1, 2022

Release 1.70.1 wordpress-mobile/gutenberg-mobile#4518

Merged

4 tasks

hypest mentioned this pull request Feb 1, 2022

[RNMobile] Video preview not launching on Android 11 #38375

Closed

hypest mentioned this pull request Feb 2, 2022

Native Mobile current focus areas #38407

Closed

hypest linked an issue Feb 3, 2022 that may be closed by this pull request

[RNMobile] Video preview not launching on Android 11 #38375

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Declare package visibility to query URL handler apps#38377

Declare package visibility to query URL handler apps#38377
hypest merged 2 commits intotrunkfrom
rnmobile/38375-fix-declare-package-visibility-needs-to-query-url-handlers

hypest commented Jan 31, 2022 •

edited

Loading

Uh oh!

mchowning left a comment

Uh oh!

hypest commented Feb 1, 2022

Uh oh!

hypest commented Feb 1, 2022

Uh oh!

fluiddot Feb 1, 2022

Uh oh!

hypest Feb 1, 2022 •

edited

Loading

Uh oh!

fluiddot Feb 1, 2022

Uh oh!

fluiddot commented Feb 1, 2022

Uh oh!

hypest commented Feb 1, 2022

Uh oh!

ParaskP7 commented Feb 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

hypest commented Jan 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing Instructions

Types of changes

Checklist:

Uh oh!

mchowning left a comment

Choose a reason for hiding this comment

Uh oh!

hypest commented Feb 1, 2022

Uh oh!

hypest commented Feb 1, 2022

Uh oh!

fluiddot Feb 1, 2022

Choose a reason for hiding this comment

Uh oh!

hypest Feb 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fluiddot Feb 1, 2022

Choose a reason for hiding this comment

Uh oh!

fluiddot commented Feb 1, 2022

Uh oh!

hypest commented Feb 1, 2022

Uh oh!

ParaskP7 commented Feb 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hypest commented Jan 31, 2022 •

edited

Loading

hypest Feb 1, 2022 •

edited

Loading