[RNMobile] RichText should delete its Enter in Heading block#37279
Merged
[RNMobile] RichText should delete its Enter in Heading block#37279
Conversation
2 tasks
|
Size Change: +25 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
hypest
force-pushed
the
fix/heading-newline-fix
branch
from
7ea8ba7 to
1e0cf70
Compare
hypest
force-pushed
the
fix/heading-newline-fix
branch
from
1e0cf70 to
5b1d891
Compare
Contributor
Author
|
👋 @ajitbohra! GitHub added you automatically as a reviewer. I believe the PR here should only really affect the native mobile side of things but yeah, would appreciate a look/review from you if you have the time, thanks! 👋 @SiobhyB, added you as a reviewer to make sure the native mobile mobile side of this PR is OK, thanks! |
SiobhyB
approved these changes
Dec 10, 2021
Contributor
SiobhyB
left a comment
SiobhyB
left a comment
There was a problem hiding this comment.
I confirmed that the splitting the heading block works as expected (with no extra lines) on both Android 11 and 12 with this PR applied. 🚀
It was also interesting to learn a bit about the deleteEnter prop, thanks for adding me as a reviewer and for the fix!
Contributor
Author
|
👋 @ajitbohra, sorry for re-pinging. Let me know if you're planning to take a peek at the changes in this PR, since you are marked as a code owner, or you're happy with the reviewing that happened so far. I can then go ahead and update from trunk to resolve the |
ajitbohra
approved these changes
Dec 16, 2021
Member
ajitbohra
left a comment
ajitbohra
left a comment
There was a problem hiding this comment.
Code wise LGTM 👍
Makes sense using platform check instead of forking.
Contributor
Author
|
Updated from trunk (and develop on the gutenberg-mobile side) and tested this still working OK on physical device and emulator, and as CIs are now green, I'm going ahead with the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix for wordpress-mobile/gutenberg-mobile#4322
Related PRs
How has this been tested?
Test 1
Test 2
Follow the same steps as in Test 1, but on an Android 11 device/emulator. This is a test to confirm that the behavior is not broken on current Android version.
Types of changes
deleteEnterprop to its RichText when on native mobile. I opted for a platform conditional (versus for example forking the edit.js into edit.native.js) to avoid forking the block for this kind of small tweak. Also, opted for not defaulting the RichText component todeleteEnter=truesince that would increase the impact of the change to too many other components/blocks. The fix in this PR is targeting the heading block only. If the same issue exists in other blocks, we can reconsider where to have the fix.Checklist:
*.native.jsfiles for terms that need renaming or removal).