Repository navigation
Make Test_Widget compatible with WP_Widget - #34355
Merged
Merged
Conversation
adamziel
requested review from
anton-vlasenko,
draganescu,
gziolo,
kevin940726 and
talldan
August 27, 2021 12:53
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Sep 28, 2026
`Test_Widget::update()` in the e2e test plugin declares a single `$new_instance` parameter, while the parent `WP_Widget::update()` takes `$new_instance` and `$old_instance`. On PHP 8 this incompatible method signature is a fatal error, so WordPress refuses to activate the `gutenberg-test-widgets` plugin and `customizing-widgets.test.js` times out waiting for the plugin's Deactivate link on every run. Ports b2c4a00 (WordPress#34355) from `trunk`. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtSAAJkQ9P6vPtDumqStg8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today I noticed that running certains e2e tests locally logs the following errors:
Turns out that the signature of
Test_Widget::updateis indeed incompatible withWP_Widget::update. This PR adjusts class Test_Widget to fix these two problems.