Skip to content

Add site logo crop #31607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Sep 20, 2021
Merged

Add site logo crop #31607

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
264cb72
Extract image editor component to block-editor
ajlende May 5, 2021
21e44c4
Add site logo cropper
ajlende Jun 21, 2021
3051109
Move react-easy-crop dependency
ajlende May 7, 2021
b364af6
add @wordpress/api-fetch to block-editor
ajlende May 7, 2021
a243c16
Update lockfile
ajlende May 7, 2021
afca925
Update docs
ajlende Jun 21, 2021
1d18680
Revert setLogo and setError changes
ajlende Jun 21, 2021
549b9e9
setLogo with number instead of string
ajlende Jun 21, 2021
e410a4d
Fix container width and height when adjusting size
ajlende Jun 22, 2021
75ba23e
Merge branch 'trunk' into add/site-logo-crop
ajlende Sep 13, 2021
fa8da2a
Remove unused Icon import
ajlende Sep 13, 2021
28ba223
Mark exported image editor as experimental
ajlende Sep 13, 2021
2574192
Update package-lock.json
ajlende Sep 13, 2021
713533e
Close cropper when not selected
ajlende Sep 14, 2021
44480c7
Reset image crop state on deselect
ajlende Sep 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Close cropper when not selected
  • Loading branch information
@ajlende
ajlende committed Sep 14, 2021
commit 713533e806a8a3564a8a5af5c4f49d16a1fdbd5d
2 changes: 1 addition & 1 deletion packages/block-library/src/site-logo/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ const SiteLogo = ( {
logoId && naturalWidth && naturalHeight && imageEditing;

const imgEdit =
canEditImage && isEditingImage ? (
canEditImage && isEditingImage && isSelected ? (
<ImageEditingProvider
id={ logoId }
url={ logoUrl }
Expand Down