Closed
Conversation
|
Size Change: +561 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Mar 19, 2021
packages/e2e-test-utils/src/index.js
Outdated
| } from './observe-focus-loss'; | ||
| export { openDocumentSettingsSidebar } from './open-document-settings-sidebar'; | ||
| export { openPublishPanel } from './open-publish-panel'; | ||
| export { |
Member
There was a problem hiding this comment.
What's the motivation to make those utils part of the public API? Can they be located in the subfolder of packages/e2e-tests?
Contributor
Author
There was a problem hiding this comment.
🤔 No particular reasons, to be honest.
I'm not familiar with Guten's e2e, and just figured that utils are supposed to go in e2e-test-utils. 😅
As far as I can see, these utils are only relevant for the performance tests, so my first thought was to create a utils folder into packages/e2e-tests/specs/performance, but then I couldn't find any other "local utils".
Member
There was a problem hiding this comment.
We can start with local utils in the top level next to specs 😄
You can also try inside specs/performance unless Jest picks them up as tests.
gziolo
added
the
[Type] Automated Testing
Contributor
Author
|
I'm not able to work on it ATM, so I'm just gonna close this PR for now. Feel free to reopen and proceed if there's a need, though! 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How has this been tested?
Screenshots
Types of changes
Checklist: