Remove the subheading block #29627
Merged
Remove the subheading block #29627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Feature] Blocks
youknowriad
requested review from
TimothyBJacobs,
ajitbohra,
nerrad,
ntwb and
spacedmonkey
as code owners
Contributor
|
Oh yeah, it's time. Could we potentially move it to the block directory, so sites that actually use it have an option to install it as a plugin? |
|
Size Change: -671 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
Contributor
Author
|
I'm not sure it's worth adding to the block directory personally, it's a lot of work (setup a repo, plugin, move the code...) and the block itself, doesn't really add much value. |
Member
|
Can't we add a deprecation and convert it to a paragraph, adding a |
Contributor
Author
|
No, we can't add such deprecation, at least not at the moment since we don't support cross blocks deprecations. |
aristath
approved these changes
Mar 9, 2021
15 tasks
youknowriad
removed
the
Needs Dev Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a galaxy far far away, sometimes like more than three years ago, Gutenberg used to have a block called "Subheading", this block doesn't exist anymore, or more exactly, this block is deprecated and hidden, so users are not allowed to use it. This block never made its way into WP as stable, it was kept hidden since then.
This PR tries to remove that block because:
There's another block (text columns) in a similar situation, I wanted to start with this one first and we can see if it's something we want to expand to other blocks (or other deprecated versions of blocks that were never merged in Core)