Skip to content

Refactor and simplify navigation block CSS. #29465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 10, 2021
Merged

Refactor and simplify navigation block CSS. #29465

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
33d7b85
Retire theme.scss.
jasmussen Mar 2, 2021
e9af6fe
Group reset styles.
jasmussen Mar 2, 2021
ea39264
Retire dead CSS.
jasmussen Mar 2, 2021
d589978
Whitespace and color tweaks.
jasmussen Mar 2, 2021
801c028
Show submenus above the sibling inserter.
jasmussen Mar 2, 2021
1ed95ac
Address feedback.
jasmussen Mar 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address feedback.
  • Loading branch information
@jasmussen
jasmussen committed Mar 10, 2021
commit 1ed95ac6a3f088191411b390c38a514aee4e75bc
20 changes: 2 additions & 18 deletions packages/block-library/src/navigation-link/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
// Normalize Link and edit containers, to look mostly the same.
.wp-block-navigation-link__field .components-text-control__input.components-text-control__input, // @todo: this selector doesn't appear to target anything.
.wp-block-navigation-link__container {
border-radius: 0;

// Make it the same height as the appender to prevent a jump. Maybe revisit this.
// Make it the same height as the appender to prevent a jump.
min-height: $button-size;
}

Expand Down Expand Up @@ -39,28 +38,13 @@
}
}

// Separator. @todo: this appears unused.
.wp-block-navigation-link__separator {
margin: $grid-unit-10 0 $grid-unit-10;
border-top: $border-width solid $gray-300;
}

// Popover styles. @todo: these all appear unused.
.components-popover.wp-block-navigation-link__dropdown-content {
margin-top: -1px;
margin-left: -4px;
}

.wp-block-navigation-link__dropdown-content .components-popover__content > div {
padding: $grid-unit-10 0;
}

.wp-block-navigation .block-editor-block-list__block[data-type="core/navigation-link"] {
& > .block-editor-block-list__insertion-point {
display: none;
}
}


/**
* Menu item setup state. Is shown when a menu item has no URL configured.
*/
Expand Down