Skip to content

Try: Visual regression test coverage for Cover block #28554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: trunk
Choose a base branch
from
Open

Try: Visual regression test coverage for Cover block #28554

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
469a4df
First stab
ockham Jan 28, 2021
786e6bb
Setup
ockham Jan 28, 2021
ff81d6b
Add jest-image-snapshot as a root devDep
ockham Jan 28, 2021
62262a4
Don't create new post for each test
ockham Jan 28, 2021
0ee29cd
Revert "Don't create new post for each test"
ockham Jan 28, 2021
c17bc10
Upload image
ockham Jan 28, 2021
2c191fb
Cover Block, not Image :facepalm:
ockham Jan 28, 2021
d0546fc
Select Cover block rather than child block
ockham Jan 28, 2021
9475aa8
Add image snapshot
ockham Jan 28, 2021
35f769c
Default jest-image-snapshot settings seem to do the trick
ockham Jan 29, 2021
2d243ca
Store diffs in artifacts dir
ockham Jan 29, 2021
b1d96c5
Add frontend test
ockham Jan 29, 2021
5c24f3a
Rename image snapshots/diffs
ockham Jan 29, 2021
fcfbab0
No need to store screenshots to disk
ockham Jan 29, 2021
e11dff5
Use same selector in editor and frontend
ockham Jan 29, 2021
e4debfb
Add TODO note
ockham Jan 29, 2021
272eaf1
Enter some text content for Cover block
ockham Feb 1, 2021
5311460
Unselect the cover block (to remove the 'selected' highlight frame).
ockham Feb 1, 2021
fbf92c4
Try disabling font render hinting
ockham Feb 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add TODO note
  • Loading branch information
@ockham
ockham committed Feb 1, 2021
commit e4debfb96e6f5b2f28e90c35dc7420fbd865632f
1 change: 1 addition & 0 deletions packages/e2e-tests/specs/editor/blocks/cover.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import {
openPreviewPage,
} from '@wordpress/e2e-test-utils';

// Copied from image.test.js. TODO: Extract into @wordpress/e2e-test-utils.
async function upload( selector ) {
await page.waitForSelector( selector );
const inputElement = await page.$( selector );
Expand Down