Skip to content

Enable react-hooks/exhaustive-deps eslint rules #24914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 9, 2023
Merged

Enable react-hooks/exhaustive-deps eslint rules #24914

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5e2e459
Upgrade eslint and eslint-plugin-react-hooks and enable exhaustive-deps
kevin940726 Aug 29, 2020
1badefd
Add CHANGELOG entry
kevin940726 Sep 1, 2020
6a8447e
Update changelog with more detail
getdave Feb 9, 2023
fa90107
Alphabetise hooks
getdave Feb 9, 2023
8358467
Remove accidental prettier dep change introduced via rebase
getdave Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Alphabetise hooks
  • Loading branch information
@getdave
getdave committed Feb 9, 2023
commit fa90107deb6f3fbdd19911f7b6306b4d5552013b
2 changes: 1 addition & 1 deletion packages/eslint-plugin/configs/react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ module.exports = {
'react/no-children-prop': 'off',
'react/prop-types': 'off',
'react/react-in-jsx-scope': 'off',
'react-hooks/rules-of-hooks': 'error',
'react-hooks/exhaustive-deps': 'warn',
'react-hooks/rules-of-hooks': 'error',
},
};