-
Notifications
You must be signed in to change notification settings - Fork 4.6k
[Mobile] Link picker via fetch #23922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lukewalczak
merged 101 commits into
master
from
rnmobile/feature/link-picker-via-fetch-without-navigation
Sep 18, 2020
Merged
Changes from 1 commit
Commits
Show all changes
101 commits
Select commit
Hold shift + click to select a range
14802b9
Implement link cell component for RN link picker experiment
mkevins 8ec1a99
Use link cell in link modal UI
mkevins 866d98a
Add link cell component
mkevins ed47f53
Add link suggestion item cell component
mkevins c621a55
Implement link picker results component via fetch function
mkevins 1270065
Add link picker component
mkevins b02c759
Use link picker as subsheet in format library link modal
mkevins a74a408
Merge branch 'master' into rnmobile/feature/link-picker-via-fetch
mkevins 57fd2c6
Support search API endpoint
mkevins c8adbb8
Use ListHeaderComponent HACK for nested flatlist in scrollview
mkevins f44b30e
Merge branch 'master' into rnmobile/feature/link-picker-via-fetch
mkevins 59943fc
Revert "Use ListHeaderComponent HACK for nested flatlist in scrollview"
mkevins 4b96728
use optimised FlatList inside bottom-sheet
dratwas b3558d1
Merge branch 'master' into rnmobile/feature/link-picker-via-fetch-wit…
mkevins 4ce9237
Merge remote-tracking branch 'origin/rnmobile/bottom-sheet-flat-list'…
mkevins 73026da
Implement basic pagination
mkevins 0f78196
Merge branch 'master' into rnmobile/feature/link-picker-via-fetch-wit…
mkevins adee81a
fix android scroll on separator item
dratwas 7c535aa
Merge branch 'rnmobile/bottom-sheet-flat-list' into rnmobile/feature/…
mkevins d64f8bf
Fix prettier issues
mkevins 4f57f11
Debounce fetch on query changes
mkevins 23078e5
Add gridicons as one-offs
mkevins 8be7518
Merge branch 'master' into rnmobile/feature/link-picker-via-fetch-wit…
mkevins 9e7a756
Use default instead of named import of styles in link suggestion item
mkevins eb345e9
Use hook instead of hoc in suggestion item
mkevins 94dba57
fix bottom spacing in inserter and justifyContent
dratwas dea6d8f
add crollableContentStyle and use it
dratwas ef21b83
remove unused style
dratwas 77e3f90
render spacing view only if needed
dratwas 7d363bb
Use array literal for style instead of compose
mkevins d28755e
Add refresh gridicon
mkevins 6446be4
Implement animated loading spinner
mkevins 2a15031
Add loading icon to link picker results
mkevins ee09fd5
Merge branch 'rnmobile/bottom-sheet-flat-list' into rnmobile/feature/…
mkevins f0e32dd
Add temporary padding for testing apk
mkevins c46f59f
Update packages/components/src/mobile/bottom-sheet/index.native.js
dratwas 2b6ed2b
fix syntax error after applying suggestion
dratwas b292cea
fix: set correct height of container
dratwas 96f246f
Align link cell and link picker labels
mkevins 5a439b4
Add chevron to link cell
mkevins 59bd9b6
Left align query input and remove icon
mkevins 95ffe9e
Use native spinner with some padding
mkevins 1360519
Add apply button to link picker fullsheet
mkevins 17d5c7e
Refactor picker spinner to use hasAllSuggestions state
mkevins 99ca76e
Merge branch 'rnmobile/bottom-sheet-flat-list' into rnmobile/feature/…
mkevins c31d626
Use apply instead of check icon in ios navigation header
mkevins 152edf7
Use safearea view for fullsheet link picker
mkevins fa7b3e7
Make protocol detection case insensitive
mkevins b0fe6df
DRY up gridicons code a bit
mkevins d6e62a1
Merge branch 'master' into rnmobile/feature/link-picker-via-fetch-wit…
mkevins cf909b9
Only render cell label if it is present
mkevins 8482780
Adjust styles for picker input cell
mkevins bc495da
Fix css lint
mkevins 6c4b642
Add scheme-specific suggestion summaries
mkevins d06e560
Use "Close" for iOS back button in fullsheet
mkevins 2859bd0
Make link suggestion summary text smaller
mkevins b95238a
Use px unit in link suggestion styles
mkevins 9220783
Merge branch 'master' into rnmobile/feature/link-picker-via-fetch-wit…
mkevins b039b7f
Merge branch 'master' into rnmobile/feature/link-picker-via-fetch-wit…
dratwas 64a12d2
[WIP]Refactor to use new navigation
dratwas 978a141
change modalUI to function
dratwas cb61996
first version of working full height modal with keyboard
dratwas 58ff3a5
[WIP] generic way of handling fullscreen bottom-sheet screens
dratwas 63e44a8
add fullHeight prop to navigation-screen
dratwas 3f41b60
Add setHeight to useCallback dependencies
dratwas 86842c0
Merge branch 'rnmobile/feat/full-height-bottom-sheet-screen' into rnm…
dratwas 2443fb0
Fix issue with empty records in link picker list
dratwas 58b8a23
fix some performance issues
dratwas 8cf4c0d
remove useCallbacks since it is slower and fix the focus loop
dratwas 4adec31
fix padding bottom
dratwas 9016e1e
Fix for bottom insets
dratwas 5437f0f
move styles to scss
dratwas f9681f6
add missing spacing on the top
dratwas d6166e6
fix issue with wrong title when removing the old one
dratwas de1298c
Refactor: move screens to separate file
dratwas a9af080
Apply suggestions from design review
dratwas afffc32
remove top handler from full screen bottom sheet android
dratwas 2f272e5
Merge branch 'master' into rnmobile/feature/link-picker-via-fetch-wit…
dratwas e32e3e6
fix import of styles
dratwas 424c408
fix rest of imports
dratwas 0d4aa93
Merge branch 'master' into rnmobile/feature/link-picker-via-fetch-wit…
dratwas 3565b0c
Add page param to docs
dratwas fec19db
set type of suggestions to post
dratwas 67fba45
add cancel-circle-filled icon and use it in link picker
dratwas 062f8ae
filter empty records
dratwas f2c15a3
(Andorid): Hide keyboard before back, change icon color, remove top c…
dratwas 98684f1
hide keyboard first on Android
dratwas 13b1df7
fix icon colors in cell.native
dratwas f8b0275
Android fixes for animation
dratwas ce05e08
change the icon color
dratwas 54192c6
remove old tests
dratwas 16c4e38
remove unused file and some cleanup
dratwas 1380410
Merge branch 'master' into rnmobile/feature/link-picker-via-fetch-wit…
dratwas 5d1691d
iOS close to cancel / Android arrow left icon to cancel icon
dratwas 57689df
Fix initial selection
dratwas 4a12d0b
change color of clear icon in link picker
dratwas 84fa7fd
Back comment about supported endpoints
lukewalczak bfe859f
Merge branch 'master' into rnmobile/feature/link-picker-via-fetch-wit…
lukewalczak 4679f08
Update changelog
lukewalczak 91c83dd
Merge branch 'master' into rnmobile/feature/link-picker-via-fetch-wit…
lukewalczak a346bba
Add missing colors for link picker
lukewalczak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Support search API endpoint
- Loading branch information
commit 57fd2c6688ae4822251e2b080d1e044f1dd7d99e
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.