Skip to content

Navigation Block: Add submenu chevron w/ setting #19601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jan 21, 2020
Merged

Navigation Block: Add submenu chevron w/ setting #19601

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
31c5008
Initialize setting in the nav block settings panel
WunderBart Jan 13, 2020
97c2675
Add submenu icon
WunderBart Jan 16, 2020
dec135b
Register "showSubmenuIcon" attributes
WunderBart Jan 16, 2020
2799273
Add submenu icon to front-end of the page
WunderBart Jan 16, 2020
1493b70
Update submenu icon setting description
WunderBart Jan 16, 2020
3511288
Don't use <span> for RichText element
WunderBart Jan 16, 2020
de772cb
Isolate NavigationLink icons
WunderBart Jan 16, 2020
b3ffd0c
Clean up a little
WunderBart Jan 16, 2020
c8092b8
Use <span> for NavigationLink contents
WunderBart Jan 17, 2020
b7bab04
Rename `$level_zero` to `$is_level_zero`
WunderBart Jan 21, 2020
41b1b49
Add missing spaces
WunderBart Jan 21, 2020
cfdf2ac
Update submenu icon selector in style.scss
WunderBart Jan 21, 2020
69778ae
Add comment about span-wrapping
WunderBart Jan 21, 2020
22b1f8c
Fix phpcs errors
WunderBart Jan 21, 2020
392fa7e
Remove unused styles
WunderBart Jan 21, 2020
f562b8a
Fix failing e2e tests
WunderBart Jan 21, 2020
5535d9b
Update failing snapshots
WunderBart Jan 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comment about span-wrapping
  • Loading branch information
@WunderBart
WunderBart committed Jan 21, 2020
commit 69778ae5fd0d93f3ed9c041efdba70f1dd14034a
2 changes: 1 addition & 1 deletion packages/block-library/src/navigation/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ function build_navigation_html( $attributes, $block, $colors, $font_sizes, $is_l
// End appending HTML attributes to anchor tag.

// Start anchor tag content.
$html .= '><span>';
$html .= '><span>'; // Wrap title with span to isolate it from submenu icon.
if ( isset( $block['attrs']['label'] ) ) {
$html .= wp_kses(
$block['attrs']['label'],
Expand Down