Skip to content

Keep user in website editor while setting up site icon via website logo #84679

Open

Description

@Drivingralle

Description

If a user clicks the link pointing to a place where to edit the website icon while editing the website logo block, a new tab with the old settings page is opened.

I think it would be nice to keep the user inside the website editor. The identity settings allow setting up the icon, too.

I have created a PR. The PR only changes the href pointing to the new setting page. For now I keeps opening a extra tab/window to edit the icon. I guess it would be even better to keep the user in the same tab.

Step-by-step reproduction instructions

  1. Open website in website editor.
  2. Edit Header template
  3. if missing add a site logo
  4. Select or edit the site logo
  5. Open side bar
  6. Review link art the bottom of the settings panel

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    [Type] BugAn existing feature does not function as intended

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions