Skip to content

Inset Blue Focus Ring on Vertical Tabs #65863

Closed

Description

@jeryj

Description

The vertical tabs have a regression in their focus styles where it is inset from the highlighted indicator.

Step-by-step reproduction instructions

  • Go to the Preferences Pane
  • Go to the tabs
  • Use the arrow keys to move between the tabs
  • Blue focus ring is inset from the gray indicator

Screenshots, screen recording, code snippet

Patterns Category Tabs
Inserter pattern tab with inset focus ring

Preferences Tabs
Image

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Activity

  1. added
    [Type] BugAn existing feature does not function as intended
    on Oct 3, 2024
  2. jeryj commented on Oct 3, 2024

    @jeryj
    ContributorAuthor

    @ciampo @DaniGuardiola @t-hamano - Pinging because it looks like y'all have been working hard on the animation improvement from #64926 :)

  3. DaniGuardiola commented on Oct 3, 2024

    @DaniGuardiola
    Member

    Those screenshots are from an older version of Tabs. If you try the latest trunk you'll see the changes that I think fit what you're after in this issue, let me know :)

  4. DaniGuardiola commented on Oct 3, 2024

    @DaniGuardiola
    Member

    Ah, wait, I think the PR that was supposed to take care of this failed to merge due to test errors. Let me take a look. In any case, the associated PR should be closed, though appreciate the effort!

  5. jeryj commented on Oct 3, 2024

    @jeryj
    ContributorAuthor

    I tested out #65387 and it looks like it fixes this well. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

[Status] In ProgressTracking issues with work in progress[Type] BugAn existing feature does not function as intended

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions