Skip to content

Explain meaning for filter operators #60238

Closed

Description

@Presskopp

Description

Please add translator comments to the filter operators Is not all, Is all, Is none and Is any (all to find in index.js). At least "Is not all" is ambigious. Does it mean "(is NOT x) AND (is NOT y) ..." or does it mean "Is not IN (x,y)".
Please mark as well that those 4 are labels.

Activity

  1. added
    [Type] BugAn existing feature does not function as intended
    on Mar 27, 2024
  2. jordesign commented on Mar 28, 2024

    @jordesign
    Contributor

    Hi @Presskopp - are you able to provide a little more detail of which block, or area of functionality this is referring to?

  3. Presskopp commented on Mar 28, 2024

    @Presskopp
    ContributorAuthor

    I'm sorry. I have no clue to be honest. Just trying to translate and did have a look at the sourcecode.

  4. swissspidy commented on Mar 28, 2024

    @swissspidy
    Member

    These are strings used in data views.

    See packages/dataviews/src/filter-summary.js and packages/dataviews/src/constants.js

    I have to say, i18n in data views really is not up to standards at the moment, lots of room for improvement there in general.

  5. github-actions commented on Apr 13, 2024

    @github-actions

    Help us move this issue forward. This issue is being marked stale since it has no activity after 15 days of requesting more information. Please add info requested so we can help move the issue forward. Note: The triage policy is to close stale issues that need more info and no response after 2 weeks.

  6. added
    [Status] StaleGives the original author opportunity to update before closing. Can be reopened as needed.
    on Apr 13, 2024
  7. removed
    [Status] StaleGives the original author opportunity to update before closing. Can be reopened as needed.
    on Apr 13, 2024
  8. priethor commented on Aug 7, 2026

    @priethor
    Contributor

    #73671 took care of this. The operators now use the clearer "Includes", "Is none of", and "Includes all" labels, with translator context for the labels and summaries. Those changes are still in trunk, so I think we can close this one. Please reopen if any of the current operators still need more context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    [Feature] DataViewsWork surrounding upgrading and evolving views in the site editor and beyond[Package] i18n/packages/i18n[Type] BugAn existing feature does not function as intended

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions