Navigation: Possible to create two navigations by mistake #56248

Activity

1. scruffian

   added

   [Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended

   [Block] NavigationAffects the Navigation BlockAffects the Navigation Block

   on Nov 17, 2023
2. getdave commented on Nov 17, 2023

   

   getdave

   on Nov 17, 2023

   Contributor

   More actions

   I wonder if we ought to move these actions to the Core Data store? That way they would be global and we could therefore globally observe their state via useSelect and control the UI accordingly.
3. getdave commented on Nov 21, 2024

   

   getdave

   on Nov 21, 2024

   Last edited by getdave

   Contributor

   More actions

   This is still possible today. We should immediately disable the button after it's been clicked.

   Logic can be added here pretty easily

   gutenberg/packages/block-library/src/navigation/edit/deleted-navigation-warning.js

   Lines 16 to 20 in b7d989e

   	<Button
   	__next40pxDefaultSize
   	onClick={ onCreateNew }
   	variant="link"
   	/>
4. getdave

   added

   Good First IssueAn issue that's suitable for someone looking to contribute for the first timeAn issue that's suitable for someone looking to contribute for the first time

   on Nov 21, 2024
5. talldan

   closed this as completedin #67488on Dec 3, 2024