Repository navigation
Font library: add support for detailed error messaging in API and UI #54777
Description
Description
The current implementation of API doesn't return detailed error when a font upload fails. Because of this reason, it is not possible to show appropriate error message in the UI.
Return detailed error messages from the API.
Step-by-step reproduction instructions
Try uploading a .otf file, and observe that API doesn't return any relevant error message or type.
Screenshots, screen recording, code snippet
No response
Environment info
- Gutenberg trunk
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
Activity
properlypurple commentedon Sep 25, 2023
I was able to reproduce this on WP 6.4-alpha-56670, with Gutenberg 16.7.0-rc.1. The screenshot below shows a toast saying
Error inserting fonts, but it's in the layer below the fonts modal, and is not very visible.madhusudhand commentedon Sep 26, 2023
@jasmussen can you suggest error messaging designs and message copy for the following scenarios.
Upload successfulmessage and no designs required)Failure reasons:
jasmussen commentedon Sep 26, 2023
Sure. For the time being, I would keep these as notices, right below the gray upload box. I would keep them all at the yellow warning level, unless it's an upload successful, then it can be green. As noted elsewhere, in the future we should redirect to the uploaded font in the Library tab instead of showing the green notice.
Please note that many of these messages are also to be found in the
packages/media-utils/src/utils/upload-media.jsfile and others. In general all these messages should be the same, regardless of whether it's for fonts or images. If you know of other places where error messages live, and that place has copy that can work for you better than my suggestions here, please use those instead. Use the below suggestions only if the precise use case isn't shown. CC: @Mamaduka in case he has insights here.Failure copy suggestions:
"Upload successful".
"Upload failed".
"Sorry, you are not allowed to upload this file type."
"Sorry, you are not allowed to upload this file type."
"Sorry, you do not have permission to upload."
"Sorry, WordPress does not have permission to upload."
Question, do we simply omit the duplicated fonts and upload any variants that are missing?
In that case, "Upload successful." — no reason to call this out, IMO.
"Upload failed."
Mamaduka commentedon Sep 26, 2023
I believe beside media upload util the remaining failure/validation errors are from server. Generally the
_wp_handle_uploadmethod handles media uploads in core.annezazu commentedon Sep 27, 2023
Pulling this feedback from the FSE Outreach Program as these concerns are coming up there:
Another piece of feedback on this note from the same call for testing:
Proper error messaging would go along way, perhaps along with an "allowed file type" note.
jasmussen commentedon Sep 28, 2023
I want to direct attention back to the initial mockups, which currently look like this:
Note here the message below the Upload dropzone that says:
I believe the separate upload tab is still being developed in a separate PR, so I'm sharing this mostly as a note to remember to go back to the mockups, a lot of detail is captured there.
That said, I wouldn't mind if it were possible to include the extension information in the upload notice as well. So potentially something like:
hanneslsm commentedon Oct 13, 2023
I find the messages too nondescriptive.
This post has excellent examples for better error messages: https://www.thegiggal.com/ux-writing-error-messages/
It'd be wonderful if we could at least include some of the points:
hanneslsm commentedon Oct 13, 2023
Also noting that in the current implementation the error messages disappear automatically after a few secs. This shouldn't happen.
creativecoder commentedon Apr 6, 2024
I think error messages have been generally improved since the REST API updates and refactor in Jan. Can we close this one?
madhusudhand commentedon Apr 19, 2024
Error messaging improved in latest releases and closing this as it is no longer applicable.