Skip to content

Improve invalid navigation menu links #42908

Closed

Description

@talldan

What problem does this address?

When testing, I couldn't get the feature introduced in #31716 to work correctly.

These tooltips never seems to display:

They're supposed to show the text "This item has been deleted, or is a draft" or "This item is missing a link", which seems important. The problem is that the tooltips are anchored to React Fragments so won't ever be positioned, and that seems to have been the case since the introduction of the feature (you can see the tooltips never appear in the gifs in the PR).

It also doesn't consider a link to a post that has been deleted as invalid, only one that's currently in the trash.

Another problem is that if a link to a draft is present, the label isn't editable. This is something a user would want to do if they're in the process of launching a new page on their website. It seems like this was a late addition to the PR (#31716 (comment)), so probably wasn't tested fully.

Also note that there's a separate issue around this feature in that it can spawn a lot of individual HTTP requests (#42904).

What is your proposed solution?

I did see whether fixing the tooltip would be a quick thing, but IMO it doesn't look good given the way it overlaps the toolbar. It looks very cluttered:
Screen Shot 2022-08-03 at 1 49 50 pm

It might be better to move the more detailed status information into the LinkControl popover.

Activity

  1. priethor commented on Aug 7, 2026

    @priethor
    Contributor

    Looks like the individual problems reported here are covered by later changes. #68628 replaced the broken tooltips with visible invalid and draft states, #73142 added handling and recovery UI for deleted entities, and #74054 clarified the invalid and draft explanations in the Link controls. Draft labels can also be changed through the inspector's Text field, added in #45964, although the status label on the canvas itself remains non-editable. The separate request-volume report #42904 was closed by #69633. I think we can close this as fixed, but please reopen if needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions