Fix failing e2e tests

WunderBart · WunderBart · commit f3cd72990743 · 2020-01-21T18:21:23.000+01:00
diff --git a/packages/block-library/src/navigation-link/edit.js b/packages/block-library/src/navigation-link/edit.js
@@ -157,6 +157,7 @@ function NavigationLinkEdit( {
 				<div className="wp-block-navigation-link__content">
 					<RichText
 						tagName="span"
+						className="wp-block-navigation-link__label"
 						value={ label }
 						onChange={ ( labelValue ) => setAttributes( { label: labelValue } ) }
 						placeholder={ itemLabelPlaceholder }
diff --git a/packages/block-library/src/navigation/index.php b/packages/block-library/src/navigation/index.php
@@ -205,7 +205,10 @@ function build_navigation_html( $attributes, $block, $colors, $font_sizes, $is_l
 		// End appending HTML attributes to anchor tag.
 
 		// Start anchor tag content.
-		$html .= '><span>'; // Wrap title with span to isolate it from submenu icon.
+		$html .= '>' .
+			// Wrap title with span to isolate it from submenu icon.
+			'<span class="wp-block-navigation-link__label">';
+
 		if ( isset( $block['attrs']['label'] ) ) {
 			$html .= wp_kses(
 				$block['attrs']['label'],
diff --git a/packages/e2e-tests/specs/editor/blocks/navigation.test.js b/packages/e2e-tests/specs/editor/blocks/navigation.test.js
@@ -59,7 +59,7 @@ async function updateActiveNavigationLink( { url, label } ) {
 	}
 
 	if ( label ) {
-		await page.click( '.wp-block-navigation-link__content.is-selected' );
+		await page.click( '.wp-block-navigation-link__label.is-selected' );
 
 		// Ideally this would be `await pressKeyWithModifier( 'primary', 'a' )`
 		// to select all text like other tests do.

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ async function updateActiveNavigationLink( { url, label } ) {`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`if ( label ) {`
`62`		`- await page.click( '.wp-block-navigation-link__content.is-selected' );`
	`62`	`+ await page.click( '.wp-block-navigation-link__label.is-selected' );`
`63`	`63`
`64`	`64`	// Ideally this would be `await pressKeyWithModifier( 'primary', 'a' )`
`65`	`65`	`// to select all text like other tests do.`