Skip to content

Commit 72084dc

Browse files
Embed: Add minimum width and height support (#83903)
Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
1 parent c40d889 commit 72084dc

4 files changed

Lines changed: 15 additions & 2 deletions

File tree

‎docs/reference-guides/core-blocks/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ Add a block that displays content pulled from other sites, like Twitter or YouTu
321321

322322
- **Name:** [core/embed](https://developer.wordpress.org/block-editor/reference-guides/core-blocks/core-blocks-embed/core-block-embed/)
323323
- **Category:** [embed](https://developer.wordpress.org/block-editor/reference-guides/core-blocks/core-blocks-embed/)
324-
- **Supports:** align, anchor, interactivity (clientNavigation), spacing (margin, padding)
324+
- **Supports:** align, anchor, dimensions (minHeight, minWidth), interactivity (clientNavigation), spacing (margin, padding)
325325
- **Attributes:** allowResponsive, caption, previewable, providerNameSlug, responsive, type, url
326326

327327
## File

‎packages/block-library/src/embed/README.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,9 @@ _Defined via the [`supports`](https://developer.wordpress.org/block-editor/refer
2828

2929
- [`anchor`](https://developer.wordpress.org/block-editor/reference-guides/block-api/block-supports/#anchor): `true`
3030
- [`align`](https://developer.wordpress.org/block-editor/reference-guides/block-api/block-supports/#align): `true`
31+
- [`dimensions`](https://developer.wordpress.org/block-editor/reference-guides/block-api/block-supports/#dimensions):
32+
- `minHeight`: `true`
33+
- `minWidth`: `true`
3134
- [`spacing`](https://developer.wordpress.org/block-editor/reference-guides/block-api/block-supports/#spacing):
3235
- `margin`: `true`
3336
- `padding`: `true`

‎packages/block-library/src/embed/block.json‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,10 @@
4343
"supports": {
4444
"anchor": true,
4545
"align": true,
46+
"dimensions": {
47+
"minHeight": true,
48+
"minWidth": true
49+
},
4650
"spacing": {
4751
"margin": true,
4852
"padding": true

‎packages/block-library/src/embed/style.scss‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,20 @@
1717
}
1818

1919
// Supply a min-width when inside a cover block, to prevent it from collapsing.
20-
.wp-block-cover .wp-block-embed {
20+
// :root :where() matches Global Styles specificity so a minimum set there can
21+
// win, since block library styles load first.
22+
:root :where(.wp-block-cover .wp-block-embed) {
2123
min-width: 320px;
2224
min-height: 240px;
2325
}
2426

2527
// Allow embeds to grow and shrink inside flex group blocks (Stack/Row), preventing collapse while fitting available space.
2628
.wp-block-group.is-layout-flex .wp-block-embed {
2729
flex: 1 1 0%;
30+
}
31+
32+
// Lowered like the cover minimums above.
33+
:root :where(.wp-block-group.is-layout-flex .wp-block-embed) {
2834
min-width: 0;
2935
}
3036

0 commit comments

Comments
 (0)