Skip to content

Commit 60986cd

Browse files
kushagra-goyal-14kushagra-goyal-14juanfraMamadukat-hamano
authored
Modal headings and labels missing editor text color (#71311)
* style: update header and content color to $gray-900 for better contrast * chore: update changelog.md * chore: update changelog to include modal text color fix * chore: correct heading casing in changelog * style: ensure proper text color for modal headings and content * style: update changelog and set proper editor text color for modal content * chore: remove repeated internal in CHANGELOG * chore: add entry to changelog.md * chore: correct pull request reference in changelog for Modal text color fix Co-authored-by: kushagra-goyal-14 <kush123@git.wordpress.org> Co-authored-by: juanfra <juanfra@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: ghorivipul97 <ghorivipul97@git.wordpress.org> Co-authored-by: falgunihdesai <falgunihdesai@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org>
1 parent aad5ae1 commit 60986cd

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

packages/components/CHANGELOG.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
## Unreleased
44

5+
### Bug Fixes
6+
7+
- `Modal`: Fix modal headings and labels to use proper editor text color instead of wp-admin colors ([#71311](https://github.com/WordPress/gutenberg/pull/71311)).
8+
59
## 30.3.0 (2025-09-03)
610

711
### Bug Fixes
@@ -14,7 +18,6 @@
1418
- Upgrade `framer-motion` package to version `^11.15.0` ([#71442](https://github.com/WordPress/gutenberg/pull/71442)).
1519
- Display names for Context providers [#71208](https://github.com/WordPress/gutenberg/pull/71208).
1620

17-
1821
## 30.2.0 (2025-08-20)
1922

2023
### Bug Fixes

packages/components/src/modal/style.scss

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,19 @@
3131
overflow: hidden;
3232
// Have the content element fill the vertical space yet not overflow.
3333
display: flex;
34+
color: $gray-900;
3435
// Animate the modal frame/contents appearing on the page.
3536
animation-name: components-modal__appear-animation;
3637
animation-fill-mode: forwards;
3738
animation-timing-function: cubic-bezier(0.29, 0, 0, 1);
3839

40+
// Ensure all headings use the proper editor text color, overriding wp-admin common.css
41+
h1,
42+
h2,
43+
h3 {
44+
color: $gray-900;
45+
}
46+
3947
@media not (prefers-reduced-motion) {
4048
animation-duration: var(--modal-frame-animation-duration);
4149
}

0 commit comments

Comments
 (0)