Skip to content

Commit 58bd2f3

Browse files
committed
Wait for both navigation requests in the router navigate e2e test.
1 parent e853022 commit 58bd2f3

1 file changed

Lines changed: 19 additions & 4 deletions

File tree

‎test/e2e/specs/interactivity/router-navigate.spec.ts‎

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,15 +78,29 @@ test.describe( 'Router navigate', () => {
7878
await expect( navigations ).toHaveText( '0' );
7979
await expect( status ).toHaveText( 'idle' );
8080

81-
let resolveLink1: Function;
82-
let resolveLink2: Function;
81+
let resolveLink1: () => void;
82+
let resolveLink2: () => void;
83+
let resolveLink1Request: () => void;
84+
let resolveLink2Request: () => void;
85+
const link1Request = new Promise< void >( ( resolve ) => {
86+
resolveLink1Request = resolve;
87+
} );
88+
const link2Request = new Promise< void >( ( resolve ) => {
89+
resolveLink2Request = resolve;
90+
} );
8391

8492
await page.route( link1, async ( route ) => {
85-
await new Promise( ( r ) => ( resolveLink1 = r ) );
93+
resolveLink1Request();
94+
await new Promise< void >( ( resolve ) => {
95+
resolveLink1 = resolve;
96+
} );
8697
await route.continue();
8798
} );
8899
await page.route( link2, async ( route ) => {
89-
await new Promise( ( r ) => ( resolveLink2 = r ) );
100+
resolveLink2Request();
101+
await new Promise< void >( ( resolve ) => {
102+
resolveLink2 = resolve;
103+
} );
90104
await route.continue();
91105
} );
92106

@@ -96,6 +110,7 @@ test.describe( 'Router navigate', () => {
96110
await expect( navigations ).toHaveText( '2' );
97111
await expect( status ).toHaveText( 'busy' );
98112
await expect( title ).toHaveText( 'Main' );
113+
await Promise.all( [ link1Request, link2Request ] );
99114

100115
await Promise.resolve().then( () => resolveLink2() );
101116

0 commit comments

Comments
 (0)