Skip to content

Commit 157b176

Browse files
committed
fix: sync the validation with integer
1 parent 93c776c commit 157b176

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

packages/dataviews/src/field-types/number.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,17 +39,14 @@ export default {
3939
isValid: {
4040
custom: ( item: any, field: NormalizedField< any > ) => {
4141
const value = field.getValue( { item } );
42-
const numericValue = Number( value );
4342

44-
if ( ! isEmpty( value ) && ! Number.isFinite( numericValue ) ) {
43+
if ( ! isEmpty( value ) && ! Number.isFinite( value ) ) {
4544
return __( 'Value must be a number.' );
4645
}
4746

4847
if ( field?.elements ) {
4948
const isMember = field.elements.some(
50-
( element ) =>
51-
Number.isFinite( Number( element.value ) ) &&
52-
Number( element.value ) === numericValue
49+
( element ) => element.value === Number( value )
5350
);
5451
if ( ! isMember ) {
5552
return __( 'Value must be one of the elements.' );

0 commit comments

Comments
 (0)