Try breaking DisableNonPageContentBlocks into separate useEffect calls

talldan · talldan · commit 0cef3d4ed56c · 2024-12-11T16:09:53.000+08:00
diff --git a/packages/editor/src/components/provider/disable-non-page-content-blocks.js b/packages/editor/src/components/provider/disable-non-page-content-blocks.js
@@ -84,9 +84,6 @@ export default function DisableNonPageContentBlocks() {
 					setBlockEditingMode( clientId, 'contentOnly' );
 				}
 			}
-			for ( const clientId of disabledIds ) {
-				setBlockEditingMode( clientId, 'disabled' );
-			}
 		} );
 
 		return () => {
@@ -98,7 +95,7 @@ export default function DisableNonPageContentBlocks() {
 				}
 			} );
 		};
-	}, [ templateParts, isNavigationMode, registry, disabledIds ] );
+	}, [ templateParts, isNavigationMode, registry ] );
 
 	useEffect( () => {
 		const { setBlockEditingMode, unsetBlockEditingMode } =

Original file line number	Diff line number	Diff line change
`@@ -84,9 +84,6 @@ export default function DisableNonPageContentBlocks() {`
`84`	`84`	`setBlockEditingMode( clientId, 'contentOnly' );`
`85`	`85`	`}`
`86`	`86`	`}`
`87`		`- for ( const clientId of disabledIds ) {`
`88`		`- setBlockEditingMode( clientId, 'disabled' );`
`89`		`- }`
`90`	`87`	`} );`
`91`	`88`
`92`	`89`	`return () => {`
`@@ -98,7 +95,7 @@ export default function DisableNonPageContentBlocks() {`
`98`	`95`	`}`
`99`	`96`	`} );`
`100`	`97`	`};`
`101`		`- }, [ templateParts, isNavigationMode, registry, disabledIds ] );`
	`98`	`+ }, [ templateParts, isNavigationMode, registry ] );`
`102`	`99`
`103`	`100`	`useEffect( () => {`
`104`	`101`	`const { setBlockEditingMode, unsetBlockEditingMode } =`