Repository navigation
Conversation
ishitaj34
marked this pull request as ready for review
October 14, 2026 06:10
ishitaj34
force-pushed
the
fix/issue-879
branch
from
October 19, 2026 11:30
de99c7b to
efebb92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #879
Prevents the Localize Text feature from wrapping empty block attribute values in translation calls during theme export.
Why?
When exporting a theme with localized text, any block attribute that had an empty string as its value was being written as, for example:
<!-- wp:post-excerpt {"moreText":"<?php esc_attr_e('', 'my-theme');?>"} /-->This caused two issues:
WordPress.WP.I18n.NoEmptyStrings).How?
In
includes/create-theme/theme-locale.php:escape_block_attribute_strings: Added an empty string check to the skip condition. If all localizable attributes on a block are empty,$modifiedstaysfalseand the original block markup is returned unchanged without re-serializing attributes.escape_block_attribute: Added defensive guards to return empty or already-escaped strings unchanged, matching the behavior ofescape_text_content()andescape_attribute().In
tests/CbtThemeLocale/escapeBlockAttributes.php:esc_attr_e().Testing Instructions
Unit tests:
npm run test:unit:php:setupto start wp-env.npm run test:unit:php:base -- --filter CBT_Theme_Locale_EscapeBlockAttributes. All tests should pass with 0 failures.Manual test:
<!-- wp:post-excerpt {"moreText":""} /-->and is not wrapped in<?php esc_attr_e('', '...');?>.Use of AI Tools