Repository navigation
fix: add Accordion heading text localization - #873
Open
kushagra-goyal-14 wants to merge 1 commit into
Open
kushagra-goyal-14 wants to merge 1 commit into
kushagra-goyal-14 wants to merge 1 commit into
Conversation
Add core/accordion-heading support to the text localization handler so Accordion titles are translation-ready when saving theme changes with Localize Text enabled. Preserve title formatting and leave toggle icons unchanged. Add regression tests for plain titles, bold text, and repeated localization. Fixes WordPress#867
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #867.
Accordion titles are currently skipped when saving theme changes with “Localize Text” enabled.
This adds
core/accordion-headingto the text localization handler and targets the title inside.wp-block-accordion-heading__toggle-title. Plain titles and titles containing bold text become translation-ready, while the toggle icon stays unchanged.Adds regression tests for plain titles, bold text, and repeated localization.
Testing instructions
patternsdirectory.The Accordion title should contain translation code using the theme’s text domain. The toggle icon should remain unchanged.
Validation