Skip to content

Add figcaption escaping for image and video blocks#745

Merged
matiasbenedetto merged 2 commits intotrunkfrom
add/escape-figacption-for-video-and-image-blocks
Nov 11, 2024
Merged

Add figcaption escaping for image and video blocks#745
matiasbenedetto merged 2 commits intotrunkfrom
add/escape-figacption-for-video-and-image-blocks

Conversation

@matiasbenedetto
Copy link
Copy Markdown
Contributor

What?

  • Adds figcaption escaping for image and video blocks
  • Updates the image block text locale test
  • Adds video block text locale test

Why?

Fixes: #735

Copy link
Copy Markdown
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well for me on video and image blocks 👏 And I can see it fixes the issue described in #735.

Video block:

image

Image block:

image

Thank you!

@matiasbenedetto matiasbenedetto merged commit ea309e0 into trunk Nov 11, 2024
@matiasbenedetto matiasbenedetto deleted the add/escape-figacption-for-video-and-image-blocks branch November 11, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Figcaption doesn't become translation ready

2 participants