Fix Image URL Localization URI#720
Conversation
There was a problem hiding this comment.
This seems to work fine; it could be merged. However, I found some issues (not strictly related to this change) when creating child themes and bundling images. For example, If I added an image in a child theme and when creating the child theme, the image was bundled in the parent theme, that would need to be fixed, too.
madhusudhand
left a comment
There was a problem hiding this comment.
It is failing in the following scenario.
Steps:
- Active a block theme such as
remoteand create a child theme. - Now add an image to the child theme, and save.
- Now save changes to theme by selecting
Save Template Changes,Localize Text,Localize Images. - Observe that the template localizes the image with
get_template_directory_uri() - But the image fails to load in the editor.
|
@madhusudhand |
madhusudhand
left a comment
There was a problem hiding this comment.
@shimotmk Thanks for addressing the feedback.
Changes looks good to me! 🚀
vcanales
left a comment
There was a problem hiding this comment.
@matiasbenedetto For example, If I added an image in a child theme and when creating the child theme, the image was bundled in the parent theme, that would need to be fixed, too.
I think we can address that situation after this fix is merged.
I fixed the image URI path as per this issue.
fix #714