Merged
Conversation
This test is only possible with the flawed way of editing the templates markup previously used. Characters like '<' '>' are encoded by core for secutiry reasons See: https://github.com/WordPress/wordpress-develop/blob/53b75a10fce4e0bae751e5a17b4c72835b2dde83/src/wp-includes/blocks.php#L1131-L1141 For that reason the php translation marks can not be added there. Still that attribute doesn't seem to be used in the core/cover block rendering so apparently with the escaping of the HTML alt attribute is enough to make the alt text of this block translatable.
pbking
reviewed
May 16, 2024
Contributor
|
I had one teeny tiny inconsequential nit. This is great to bring in and fixes the problem at hand and enhances the tests quite a bit. |
pbking
approved these changes
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fix template texts localizing/escaping.
Fixes: #632
Why?
The current implementation consisting of:
This approach is flawed because it fails, for example, when there are substrings. The problem is explained in this comment: #632 (comment)
☣️ The severity of the problem is high because the resulting templates/patterns are broken because the plugin is producing invalid markup.
How?
This PR improves the approach around escaping block strings for translation. It avoids the substring problem by just considering the HTML content block by block.
The new implementation consist of:
parse_blocks().serialize_blocks()function.